19 How great is the goodness
    you have stored up for those who fear you.
You lavish it on those who come to you for protection,
    blessing them before the watching world.
20 You hide them in the shelter of your presence,
    safe from those who conspire against them.
You shelter them in your presence,
    far from accusing tongues.

21 Praise the Lord,
    for he has shown me the wonders of his unfailing love.
    He kept me safe when my city was under attack.
22 In panic I cried out,
    “I am cut off from the Lord!”
But you heard my cry for mercy
    and answered my call for help.

23 Love the Lord, all you godly ones!
    For the Lord protects those who are loyal to him,
    but he harshly punishes the arrogant.
24 So be strong and courageous,
    all you who put your hope in the Lord! NLT

David came through his troubles with a testimony. He proved God (19-22), and was then able to encourage others to trust in his trustworthy Lord (23,24).

” And we know that in all things God works for the good of those who love him, who have been called according to his purpose.” Rom. 8:28 NIV

For David, this included experiencing God’s protection when he was in a ‘besieged city’ (21b). This probably doesn’t refer to any one particular location, but more metaphorically to the sense of being ‘hemmed in’. In that case, we also have spent time in that city.

David’s life was not trouble-free. (Obviously!) But for centuries, a ”watching world” (19b) has been able to look on and see what a God-blessed life looks like – yes, even amid sin and failure.